[chore] add triton-ascend to requirements.txt #4294
Conversation
Signed-off-by: wxh571001500 <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds triton-ascend as a dependency in requirements.txt. However, the corresponding pyproject.toml file was not updated. To maintain consistency and prevent potential build issues, this dependency should also be added to pyproject.toml's build-system.requires list, as is the convention in this repository.
Signed-off-by: wxh571001500 <[email protected]>
|
title should be [core]xxx ? |
"Chore" means the activity of building processes or supporting tools. Or would my change be more suitable for other keywords? |
Signed-off-by: wxh571001500 <[email protected]>
Signed-off-by: wxh571001500 <[email protected]>
My mistake, it's ok to use chore. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Since there is currently no stable version of triton-ascend, it will be temporarily shut down. |
2 participants
What this PR does / why we need it?
Previously, when adapting vllm-ascend to models such as Qwen-Next, users needed to install the triton_ascend dependency separately. Therefore, to improve usability, the dependency is now included in requirements.txt and installed along with vllm-ascend.
Does this PR introduce any user-facing change?
nope
How was this patch tested?
After installing vllm-ascend, we can use “pip list” to observe that triton-ascend is also installed synchronously.